New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove duplicate response logging in the browser console #1418
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b594029:
|
Thanks for adding this, @snaka! |
I have a problem with that. I ran My working environment is Windows (WSL2). The tests run by GitHub Actions seemed to be using a virtual macOS, so I was wondering about that. |
Sorry. |
Hey, @snaka. No worries. I know it can be challenging to run PW on other systems. I will checkout your branch and help you with the test when I have a minute. |
Thanks @kettanaito . It is very helpful. |
I've added the integration test for this fix 👍 Also found some shared state issue in the existing unit test, fixed that as well (I believe that one has been failing the CI). |
I've found another issue that |
Thank you for helping fix this, @snaka! Welcome to contributors. |
Thank you @kettanaito for your support. |
Released: v0.47.4 🎉This has been released in v0.47.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Update
strict-event-emitter
version that to resolve log duplicates.