Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename "SetupWorkerApi"/"SetupServerApi" types to "SetupWorker"/"SetupServer" #1478

Conversation

gduliscouet-ubitransport
Copy link
Contributor

Follow-up to the first PR, with breaking changes

Completes the fix to #1454

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 914bae8:

Sandbox Source
MSW React Configuration

BREAKING CHANGE: export the SetupWorkerApi class instead of the interface
BREAKING CHANGE: export the SetupServerApi class instead of the interface
@gduliscouet-ubitransport gduliscouet-ubitransport force-pushed the fix/export-setup-class-instead-of-interface branch from b9bd4e0 to 0553ff6 Compare November 28, 2022 09:01
@kettanaito kettanaito changed the title Fix/export setup class instead of interface feat: rename "SetupWorkerApi" type to "SetupWorker" Dec 7, 2022
@kettanaito kettanaito changed the title feat: rename "SetupWorkerApi" type to "SetupWorker" feat: rename "SetupWorkerApi"/"SetupServerApi" types to "SetupWorker"/"SetupServer" Dec 7, 2022
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great. Thanks for following on this, @gduliscouet-ubitransport! Let's wait for the CI to pass, the previous integration tests run failed.

@kettanaito kettanaito merged commit 4fde47e into mswjs:main Jan 24, 2023
@kettanaito
Copy link
Member

Released: v1.0.0 🎉

This has been released in v1.0.0!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

@kettanaito
Copy link
Member

Well, sir, your pull request has just bumped MSW to its first stable version (absolutely 0 fault on your side, it's my screw-up). Well, I didn't intend for that to happen but I'm thinking we can roll with that. The API has been stable for at least 3 years, with no major changes introduced whatsoever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants