fix: give node export condition higher priority
#2134
Merged
+26
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case of mixed environments that look for both "node" and "browser" export conditions
kettanaito
changed the title
node condition high prioritynode export condition higher priority
kettanaito
reviewed
Apr 17, 2024
| "types": "./lib/node/index.d.ts", | ||
| "node": { |
There was a problem hiding this comment.
Let's do the same for /native export too?
kettanaito
reviewed
Apr 17, 2024
| "types": "./lib/node/index.d.ts", | ||
| "node": { |
There was a problem hiding this comment.
Also, a reverse fix for /browser? Adding a browser field with a higher priority. Folks experience the reverse problem as well for msw/browser.
kettanaito
reviewed
Apr 17, 2024
| @@ -115,6 +115,15 @@ function validateExportConditions(pointer, conditions) { | |||
| return | |||
| } | |||
|
|
|||
| if (typeof relativeExportPath === 'object') { | |||
| validateExportConditions( | |||
There was a problem hiding this comment.
Ouch! Thank you for spotting this. We didn't have any support for nested export conditions. This is nice ❇️
phryneas
force-pushed
the
pr/node-exports-condition
branch
from
530dcdf to
79ce316
Compare
kettanaito
approved these changes
Apr 17, 2024
1 task
Released: v2.2.14 🎉This has been released in v2.2.14! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of mixed environments that look for both
"node" and "browser" export conditions