Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve trailing optional path parameters #2169

Merged
merged 3 commits into from
Jun 1, 2024
Merged

fix: preserve trailing optional path parameters #2169

merged 3 commits into from
Jun 1, 2024
+94 −20

Conversation

kettanaito
Copy link
Member

@kettanaito
test: optional path parameter matching
Loading
Loading status checks…
d328f28
@kettanaito kettanaito marked this pull request as draft May 25, 2024 06:35
@kettanaito kettanaito mentioned this pull request May 25, 2024
Closed
1 task
@KaiSpencer
Copy link
Contributor

Hey @kettanaito,

I have a fix for this. How would you like it contributing given this branch and PR already existing.

@kettanaito
Copy link
Member Author

Hi, @KaiSpencer. This should work:

  1. Fork this repo.
  2. Check out to this PR's branch.
  3. From this branch, create a new branch. Give it whichever name you wish.
  4. Commit and push your changes to the new branch to your fork as the origin.
  5. Go on GitHub and open a PR from your new branch to this feature branch.

Then I'll see it and be able to review it!

@KaiSpencer KaiSpencer mentioned this pull request May 25, 2024
Merged
@KaiSpencer @kettanaito
fix: optional path parameter matching (#2170)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
f739622 
Co-authored-by: Artem Zakharchenko <kettanaito@gmail.com>
@kettanaito kettanaito changed the title test: optional path parameter matching fix: preserve optional path parameters Jun 1, 2024
@kettanaito kettanaito changed the title fix: preserve optional path parameters fix: preserve trailing optional path parameters Jun 1, 2024
@kettanaito kettanaito marked this pull request as ready for review June 1, 2024 09:09
@kettanaito kettanaito merged commit e69bbd6 into main Jun 1, 2024
12 checks passed
@kettanaito kettanaito deleted the test/path-params-optional branch June 1, 2024 09:16
@kettanaito
Copy link
Member Author

Released: v2.3.1 🎉

This has been released in v2.3.1!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional path parameters do not match correctly
2 participants
@kettanaito @KaiSpencer