Add optional peer dependency for typescript

[willbuckingham]

Based on conversation in #975

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb3ef87:

Sandbox	Source
MSW React	Configuration

[kettanaito]

Hey, @willbuckingham. Thank you for making this improvement happen! I've left a few thoughts and would love to hear your opinion on them.

[kettanaito]

Thank you for the great work on this, @willbuckingham. I've left one comment regarding the TypeScript version range given my latest findings of how TS is versioned. Would love to hear your opinion on the suggestions.

[kettanaito]

Thank you, @willbuckingham!
Let's see if the smoke tests pass, there have been some issues with them on this branch.

[kettanaito]

Some tests fail reliably with this change. I'd have to take a look at what's causing this. There are no installation warnings due to missing typescript dependency, all examples (which are used for smoke tests) are written in JavaScript.

[amaury-hanser]

Hello, a quick comment to tell you that I'm interested in this PR.
I don't have the knowledge to fix it, but it's a PR that could be nice for the community. :)

[kettanaito]

Hey, @amaury-hanser! Thank you for showing interest in this change.

The task itself is complete here but we've got some issues with the smoke tests failing. I don't see a direct relation between adding an optional dependency and any failing tests, but there must be something we're missing.

I've rebased this branch to use our recent GitHub Actions CI. Let's see how the build goes.

[kettanaito]

This CI will pass now as I've removed smoke tests from the pull request jobs. It still fails the smoke tests, which would be nice to investigate.

[kettanaito]

This is likely to fail smoke tests. My initial guess is that the examples are rather outdated and it may force exceptions during the installation of MSW (although TS is marked as an optional dependency).

[kettanaito]

Since we are about to merge #1073 (path parameter inference), I fail to remember which version of TypeScript added that feature.

• 4.2 Release notes
• 4.3 Release notes

[kettanaito]

The pull request description mentions 4.1. Great!

[kettanaito]

Released: v0.40.0 🎉

This has been released in v0.40.0!

• 📄 Release notes
• 📦 npm package

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

---

Predictable release automation by @ossjs/release.

[piotr-cz]

I'm not able to update to v0.40.0 because of dependency conflict (I have already installed typescript@^4.6.4):

npm output:

Could not resolve dependency:
peerOptional typescript@"4.2.x" from msw@0.40.0
node_modules/msw
  msw@"*" from the root project
Conflicting peer dependency: typescript@4.2.4
node_modules/typescript
  peerOptional typescript@"4.2.x" from msw@0.40.0
  node_modules/msw
    msw@"*" from the root project

[kettanaito]

Please see the discussion in #1241.