Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate utility functions into single file. #20781

Open
ikspress opened this issue Apr 30, 2024 · 1 comment
Open

Separate utility functions into single file. #20781

ikspress opened this issue Apr 30, 2024 · 1 comment

Comments

@ikspress
Copy link
Contributor

ikspress commented Apr 30, 2024 •
edited

It just my brainstorm.
There are too many utility functions like apply_patch_with_msg revert_patch_with_msg and del_file_exists scattered in various PKGBUILDs, why not separate them into a single file (e.g. scripts/utils.sh) and use source command to load?
@Biswa96
Copy link
Member

Biswa96 commented May 1, 2024

Or, makepkg could apply the patches automatically by reading source array. I do not know if upstream ArchLinux would accept that proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Biswa96 @ikspress