Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support validating Enterprise SSO users #207

Open
lukasz-mitka opened this issue Jan 9, 2024 · 1 comment · Fixed by #209
Open

Does not support validating Enterprise SSO users #207

lukasz-mitka opened this issue Jan 9, 2024 · 1 comment · Fixed by #209
Assignees
Labels
bug Something isn't working

Comments

@lukasz-mitka
Copy link
Contributor

lukasz-mitka commented Jan 9, 2024

Description
Validation fails on checking valid enterprise sso users
Example: @user-name-can-be-very-long_and-has-underscore

Validation fails after adding SSO user to CODEOWNERS file.

Expected result
User should be validated successfully.

Actual result
Fails with

Owner @user_id does not look like a GitHub username or team name

Steps to reproduce
Add * @user_id to CODEOWNERS file

Troubleshooting
Here's the regex that doesn't match it.

usernameOrTeamRegexp = regexp.MustCompile(`^@(?i:[a-z\d](?:[a-z\d-]){0,37}[a-z\d](/[a-z\d](?:[a-z\d_-]*)[a-z\d])?)$`)

@lukasz-mitka lukasz-mitka added the bug Something isn't working label Jan 9, 2024
@lukasz-mitka
Copy link
Contributor Author

I just noticed I only fixed the _ part of this issue in #209.
The unlimited username length will still be an issue :(

@mszostok mszostok reopened this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants