Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Builds #94

Open
Kamsiy opened this issue Apr 28, 2023 · 1 comment
Open

Failing Builds #94

Kamsiy opened this issue Apr 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Kamsiy
Copy link
Contributor

Kamsiy commented Apr 28, 2023

Description

Right now, the tests for the project are currently failing due to a mismatch in dates.

For example:
Build: https://github.com/mszostok/version/actions/runs/4269505384/jobs/7432733388?pr=87
Screen Shot 2023-04-28 at 1 24 39 AM

Steps to reproduce

  • Create a pull request

Troubleshooting

  • I looked into updating the date and time for the github actions OS but this is not allowed Screen Shot 2023-04-28 at 1 33 49 AM

  • We could add some code to normalize the dates but this might hide issues in future Pull requests

  • Regenerating fixtures fixes this as well

@Kamsiy Kamsiy added the bug Something isn't working label Apr 28, 2023
@mszostok
Copy link
Owner

I'm aware of that issue. Thanks for the PR with updated assets. I will leave this issue open to figure out a proper solution. Maybe a CI that will do the update and will create a PR, sth similar to what dependabot is doing. Mocking is also an option but not sure if it will be a better one, as the final code path won't ever be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants