Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Quick Links add/edit generated error #515

Open
xXFreeFunXx opened this issue Oct 21, 2023 · 1 comment
Open

[Bug] Quick Links add/edit generated error #515

xXFreeFunXx opened this issue Oct 21, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@xXFreeFunXx
Copy link
Contributor

  1. The Name field is automatically filled with the URL if none is specified. Couldn't you read the title tag name here?
  2. The field icon (optional) will be automatically filled with the URL, this will prevent the icon from loading.
@xXFreeFunXx xXFreeFunXx added the bug Something isn't working label Oct 21, 2023
@davidcralph
Copy link
Member

I've fixed 2. for you, but 1. is difficult without API changes due to CORS.

If you want to have a go at it yourself, this is what I got to:

  async getTitle(url) {
    let title;
    try {
      let response = await fetch(url);
      if (response.redirected) {
        response = await fetch(response.url);
      }
      const html = await response.text();
      const parser = new DOMParser();
      const doc = parser.parseFromString(html, 'text/html');
      title = doc.title;
    } catch (e) {
      title = url;
    }

    return title;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants