[core] Generate CHANGELOG from GitHub API

[alexfauquette]

The goal is to get a script that will not break when GitHub updates its font-end

[m4theushw]

Did you consider that the results might be paginated? In #3312 it has 2 pages in the GitHub UI.

In the core repo, there's this script which you could take some inspiration: https://github.com/mui-org/material-ui/blob/master/scripts/releaseChangelog.js

It uses https://github.com/octokit/octokit.js instead of manually fetching the REST API.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[alexfauquette]

The script is now able to look for PR description containing # changelog. All the text after this key will be added to the changelog generated. On the same idea, we could add break changes when we will prepare v6.

[alexfauquette]

@m4theushw if you have a github token, the l10n can automatically update the issue when running yarn l10n --report. The token can be provided by adding GITHUB_TOKENin your env variables or adding the option --github_token 🎁

[m4theushw]

Finally, it's the end for the inconsistencies in the CHANGELOG between each release. 😁

[m4theushw]

Better to read it from a env var or argument.

[alexfauquette]

What about defining them as constants at the beginning of the file

GIT_ORGANIZATION = 'mui-org';
GIT_REPO = 'material-ui-x';
L10N_ISSUE_ID = 3211;

My concern is that someone debugging this code in 2 years will have every information set in a single file.

[alexfauquette]

@m4theushw The dedicated PR for translation is #3588

[m4theushw]

The highlights come before the package names.

[m4theushw]

This was not addressed.

[alexfauquette]

My bad, I moved the "TODO INSERT HIGHLIGHTS" and forget the changeLogMessages

done

[mui-bot]

These are the results for the performance tests:

Test case	Unit	Min	Max	Median	Mean	σ
Filter 100k rows	ms	167.8	411.4	220.1	250.34	85.485
Sort 100k rows	ms	445.4	692	467.7	533.1	101.04
Select 100k rows	ms	204	299	237.8	246.64	33.202
Deselect 100k rows	ms	111.5	214.3	189.9	167.52	40.848

Generated by 🚫 dangerJS against 74e7179

[alexfauquette]

I merge it because I'm doing the release this week. That will be a perfect occasion for a first test ;)