Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Refresh the license key documentation #3529

Merged
merged 12 commits into from Jan 28, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 31, 2021

https://deploy-preview-3529--material-ui-x.netlify.app/components/data-grid/getting-started/#licenses

I'm opening this PR to address questions that we frequently hear on the sales@mui.com channel and to polish.

  1. First and foremost, I distinguish the notion of license key and license the two are different. Developers shouldn't assume that the license key is everything. It's only a reminder.
  2. I update the screenshots, to be more up-to-date. I used the opportunity to add a dark mode variant for them
  3. People that ask about how to protect their license key: they don't need.

We would like to know your recommendations about how to secure the license key in our SPAs.

https://mui.zendesk.com/agent/tickets/1803

I bought MUI X Pro for myself, but if I push my code to GitLab every developer who works in my company can steal my license key and use it for free. What can I do to protect my key?

https://mui.zendesk.com/agent/tickets/1863

We stored this license key in an Environment variable within our project, but it might be accessible by unwanted 3rd parties since it's stored on the frontend side. Do you have restrictions to using this license? Maybe domain-specific?

https://mui.zendesk.com/agent/tickets/1878

how can I protect that in the future another developer can use my license when maintaining it?

https://mui.zendesk.com/agent/tickets/1900

  1. People that ask about what happens with majors

I have a license key for the Material UI 4 XGrid. Can I use the same license key for Material UI 5 Data Grid Pro?

https://mui.zendesk.com/agent/tickets/1937

Cover https://stackoverflow.com/questions/70838326/where-should-the-mui-x-pro-license-key-be-installed/70901041

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 31, 2021

Once you purchase a license, you'll receive a license key.
This key should be provided to the enterprise package to remove the watermark and
You are [free to install](https://mui.com/store/legal/mui-x-eula/#evaluation-trial-licenses) and try `DataGridPro` as long as it is not used for development of a feature intended for production.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I anticipate for what we explored in https://github.com/mui-org/mui-store/pull/81 (we reverted this PR) but still it's going to be the same URL, as far as I know.

@@ -200,10 +196,21 @@ The enterprise components come in two plans: Pro and Premium.
| [Keyboard navigation](/components/data-grid/accessibility/#keyboard-navigation) | ✅ | ✅ | ✅ |
| [Localization](/components/data-grid/localization/) | ✅ | ✅ | ✅ |

### License key installation
### Evaluation (trial) licenses
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same header as in the EULA

case LicenseStatus.NotFound:
return 'MUI X Unlicensed product';
return 'MUI X Missing license key';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was confusing

@@ -4,11 +4,11 @@ import { useLicenseVerifier, LicenseStatus } from '@mui/x-license-pro';
function getLicenseErrorMessage(licenseStatus: LicenseStatus) {
switch (licenseStatus) {
case LicenseStatus.Expired:
return 'MUI X License Expired';
return 'MUI X License key expired';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License key + heading capitalization convention. So far, we only capitalize each word for the roles (e.g. Staff Software Engineer).

@oliviertassinari oliviertassinari force-pushed the docs-improve-license branch 3 times, most recently from 435b6e9 to 8fdbdaf Compare December 31, 2021 20:12
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a few suggestions.

oliviertassinari and others added 10 commits January 28, 2022 23:35
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
@mui-bot
Copy link

mui-bot commented Jan 28, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 1,101.5 1,726.5 1,167.4 1,340.9 261.762
Sort 100k rows ms 694.3 1,260.1 694.3 949.02 210.626
Select 100k rows ms 145.1 211.6 184.8 180 22.768
Deselect 100k rows ms 86.9 164.1 86.9 113.74 27.783

Generated by 🚫 dangerJS against 32f68ae

@oliviertassinari oliviertassinari merged commit 2d4c5a8 into mui:master Jan 28, 2022
@oliviertassinari oliviertassinari deleted the docs-improve-license branch January 28, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants