[DataGrid] Fix potential memory leak warning #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
force-pushed
the
memory-leak-warning
branch
from
f9d1046
to
8828ace
Compare
m4theushw
commented
Jan 6, 2022
| {...errorProps} | ||
| {...rootProps.componentsProps?.errorOverlay} | ||
| /> | ||
| <GridAutoSizer |
There was a problem hiding this comment.
Fixes https://codesandbox.io/s/datagriddemo-material-demo-forked-49plk?file=/demo.tsx
If the error is set by the error prop, GridAutoSizer in GridBody won't render and we won't have any dimension.
|
|
||
| let height: React.CSSProperties['height'] = viewportInnerSize?.height ?? 0; | ||
| if (rootProps.autoHeight && height === 0) { | ||
| height = 'auto'; | ||
| } | ||
|
|
||
| if (!viewportInnerSize) { |
There was a problem hiding this comment.
To prevent misalignment when there's no dimension yet.
m4theushw
changed the title
m4theushw
added
bug 🐛
flaviendelangle
approved these changes
Jan 17, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3276
Preview: https://deploy-preview-3558--material-ui-x.netlify.app/components/data-grid/
I don't know why we never tried that. The warning is always triggered inside
GridOverlayas part ofGridOverlays. It turns out thatGridOverlaysis rendered beforeGridAutoSizer. That way, subscribing inside a normal effect has no risk of losing any resize event, because React executes the effects sequentially according to the tree.