[docs] Replace @mui/styles in x-data-grid-generator #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
force-pushed
the
replace-mui-styles
branch
3 times, most recently
from
0eb5319
to
64f28f9
Compare
m4theushw
force-pushed
the
replace-mui-styles
branch
from
64f28f9
to
0a2da36
Compare
m4theushw
commented
Jan 8, 2022
| ); | ||
| const Value = styled('div')(({ theme }) => ({ | ||
| width: '100%', | ||
| height: '100%', |
There was a problem hiding this comment.
packages/grid/x-data-grid-generator/src/renderer/renderEditContractType.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
9
to
19
| const StyledAutocomplete = styled(Autocomplete)(({ theme }) => ({ | ||
| [`& .${autocompleteClasses.inputRoot}`]: { | ||
| ...theme.typography.body2, | ||
| padding: '1px 0', | ||
| height: '100%', | ||
| '& input': { | ||
| padding: '0 16px', | ||
| height: '100%', | ||
| }, | ||
| }, | ||
| })); |
There was a problem hiding this comment.
I don't know why, but the autocompleteClasses.root also needs to have height: "100%". Otherwise the Autocomplete component does not fill the cell
packages/grid/x-data-grid-generator/src/renderer/renderEditCurrency.tsx
Outdated
Show resolved
Hide resolved
packages/grid/x-data-grid-generator/src/renderer/renderEditStatus.tsx
Outdated
Show resolved
Hide resolved
|
Just finished reading. The other files look good to me :) |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
These are the results for the performance tests:
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
alexfauquette
approved these changes
Jan 18, 2022
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2991
After this PR there will only a few usages of
@mui/stylesremaining.Preview: https://deploy-preview-3560--material-ui-x.netlify.app/components/data-grid/demo/
Preview: https://deploy-preview-3560--material-ui-x.netlify.app/storybook/?path=/story/datagridpro-test-rows--edit-rows-control