[DataGrid] Make row editing work with preProcessEditCellProps #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
bug 🐛
m4theushw
approved these changes
Jan 7, 2022
packages/grid/x-data-grid-pro/src/tests/editRows.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
packages/grid/x-data-grid-pro/src/tests/editRows.DataGridPro.test.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
m4theushw
reviewed
Jan 11, 2022
| fireEvent.doubleClick(cell); | ||
| const input = cell.querySelector('input')!; | ||
| fireEvent.change(input, { target: { value: 'Adidas' } }); | ||
| await clock.runToLast(); |
There was a problem hiding this comment.
Why the await here? This test is not passing on Safari.
There was a problem hiding this comment.
I spent quite some time to make this test work.
It did not on Chrome Headless without the await
But if the await causes problem then the solution is not good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3557
I think the behavior is still perfectible.
If you validation takes time and you press "Enter" before it ends, it will save the last valid value, even if it's not the one displayed on screen. Maybe it would be better to not allow committing while validating.
But I would be in favor of waiting after the row / cell file split before adding additional complexity to this feature.