[DataGrid] Fix line break characters breaking CSV rows #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cell value contains line break character, CSV export results in broken CSV since part of the value goes to the next line. Wrapping value into quotes in this case fixes the issue.
cherniavskii
force-pushed
the
csv-newlines
branch
from
e937dd2
to
98f86cd
Compare
cherniavskii
added
the
component: data grid
m4theushw
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2860
When cell value contains line break character, CSV export results in broken CSV since part of the value goes to the next line.
Wrapping value into quotes in this case fixes the issue.