[core] Add typing to the pre-processors methods #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
approved these changes
Jan 15, 2022
| type GridPreProcessorsApplierArg< | ||
| P extends GridPreProcessingGroup, | ||
| T extends { value: any }, | ||
| > = T extends { context: any } ? [P, T['value'], T['context']] : [P, T['value']]; |
There was a problem hiding this comment.
In https://github.com/mui-org/material-ui-x/pull/3595/files#diff-b1ecb3ac2bbd884ca95d8879603f25ff6f844a259f0ceb6207fb06682cc933f6R37 you changed to accept several params. How do you plan to type if we add a pre-processor that has more than 3 arguments in the apiRef.current.unstable_applyPreProcessors call.
const canBeReorderedProcessed = apiRef.current.unstable_applyPreProcessors(
GridPreProcessingGroup.canBeReordered,
canBeReordered,
{ targetIndex: targetColVisibleIndex },
hasMovedLeft,
hasMovedRight
);There was a problem hiding this comment.
This was a hack to make TypeScript accept both 1 "params" and 0 "params" without doing something like [value, params] = args as any.
But if it's not clear, maybe the as any it better.
|
These are the results for the performance tests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3593
As it do not impact the users at all, I will automerge 7 days after the review request.
I think other PRs are more worth spending time reviewing 馃憤