[test] Split cell/row editing tests #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A lot better that way |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
|
These are the results for the performance tests:
|
flaviendelangle
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3219, I think it would be better to also separate the tests. Although both edit modes share a lot of things, I find easier to see them as two complete different features. Concerning testing, the
editRows.DataGridPro.test.tsxfile has more than 1600 LOC. It's impractical to navigate between all of tests. In this PR I propose to split them into 3 new files:cellEditing.DataGridPro.test.tsxis only to test the general functionality of the cell editing.rowEditing.DataGridPro.test.tsxis similar to above but only for row editing tests.editComponents.DataGridPro.test.tsxis meant to test the edit components provided by each column type. If one component behaves differently ineditMode=rowI would add its tests here.It's not necessary to go through each file, I'm only moving the tests without changing them. I didn't automerge because I want to collect some feedback about the new structure.