-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Allow to pass csvOptions
and printOptions
to GridToolbar
#3623
Merged
flaviendelangle
merged 13 commits into
mui:master
from
flaviendelangle:export-toolbar-props
Jan 20, 2022
Merged
[DataGrid] Allow to pass csvOptions
and printOptions
to GridToolbar
#3623
flaviendelangle
merged 13 commits into
mui:master
from
flaviendelangle:export-toolbar-props
Jan 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
Jan 14, 2022
These are the results for the performance tests:
|
flaviendelangle
commented
Jan 14, 2022
m4theushw
reviewed
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left only a few suggestions for the documentation. Looks good.
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
m4theushw
approved these changes
Jan 20, 2022
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom CSV export seems to be a pretty common use can. For me it feels wrong that users have to override the whole toolbar in order to apply the slightest customization (ex: #3563, #3064, #2860, #2156, ...)
Even the doc was dodging the question by creating a very incomplete
GridToolbar
without the other built-in buttons.But most of the time, users just want to customize the CSV and/or print export, not to loose all the other features of the
GridToolbar
.I added
csvOptions
andprintOptions
toGridToolbar
and just forward them toGridToolbarExport
which makes everything a lot easierBefore:
After:
Other changes