Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Renovate should not try to update node #3645

Merged
merged 1 commit into from Jan 17, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 16, 2022

I'm doing #3362 (comment). This is done manually, for each major. I have left a note in #3287 for MUI X v6. The solution is based on renovatebot/config-help#81

So far, we have closed 11 times PRs that try to upgrade Node manually, this is no good, a distraction and a risk to break the next release.

Closes #3643
Closes #3638

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 16, 2022
@mui-bot
Copy link

mui-bot commented Jan 16, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 154.2 304.5 242.8 230.96 49.643
Sort 100k rows ms 353.5 880.4 603.7 623.4 182.253
Select 100k rows ms 194.1 284.3 220 234.34 32.79
Deselect 100k rows ms 116.4 271.3 210 188.54 61.453

Generated by 🚫 dangerJS against 325266b

@oliviertassinari oliviertassinari merged commit 48a5474 into mui:master Jan 17, 2022
@oliviertassinari oliviertassinari deleted the ignore-node-update branch January 17, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants