[core] Add eslint rule to force default export equals to filename in doc #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
flaviendelangle
approved these changes
Jan 20, 2022
m4theushw
reviewed
Jan 20, 2022
.eslintrc.js
Outdated
Comment on lines
63
to
65
| files: ['docs/src/pages/**/*.js', 'docs/src/pages/**/*.tsx'], | ||
| rules: { | ||
| 'filenames/match-exported': ['error', [null, 'kebab', 'snake']], |
There was a problem hiding this comment.
Keeping kebab and snake makes it to still suggest other names, although they can't be used because of another rule:
Maybe?
Suggested change
| files: ['docs/src/pages/**/*.js', 'docs/src/pages/**/*.tsx'], | |
| rules: { | |
| 'filenames/match-exported': ['error', [null, 'kebab', 'snake']], | |
| files: ['docs/src/pages/components/**/*.js', 'docs/src/pages/components/**/*.tsx'], | |
| rules: { | |
| 'filenames/match-exported': ['error', [null]], |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@alexfauquette Oh wow, nice! Can we move this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should never append again after #3564 (comment)