Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Remove a useless async #3675

Merged
merged 2 commits into from Jan 26, 2022
Merged

[test] Remove a useless async #3675

merged 2 commits into from Jan 26, 2022

Conversation

alexfauquette
Copy link
Member

No description provided.

@alexfauquette alexfauquette mentioned this pull request Jan 20, 2022
Merged
@mui-bot
Copy link

mui-bot commented Jan 20, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 186.3 336.1 293.4 269.18 54.219
Sort 100k rows ms 495.9 716.2 509.7 586.1 100.751
Select 100k rows ms 147 242.9 212.9 199.12 35.888
Deselect 100k rows ms 122 254.3 137.1 158.8 48.893

Generated by 🚫 dangerJS against 462173c

@m4theushw m4theushw changed the title [test] remove a useless async [test] Remove a useless async Jan 20, 2022
@m4theushw m4theushw added the test label Jan 20, 2022
m4theushw
m4theushw approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging with master first should fix argos.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 25, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 25, 2022
@alexfauquette alexfauquette self-assigned this Jan 25, 2022
@alexfauquette alexfauquette merged commit d305f5c into mui:master Jan 26, 2022
@alexfauquette alexfauquette deleted the select-tests branch January 26, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@m4theushw m4theushw m4theushw approved these changes

Assignees

@alexfauquette alexfauquette

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexfauquette @mui-bot @flaviendelangle @m4theushw