Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Skip tests on Safari #3679

Merged
merged 1 commit into from Jan 21, 2022
Merged

[test] Skip tests on Safari #3679

merged 1 commit into from Jan 21, 2022

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Jan 20, 2022 •
edited

Blob.text() is only available in Safari 14. We test in Safari 13. The CI broke after merging #3623.

@mui-bot
Copy link

mui-bot commented Jan 20, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 154.3 315.7 200.5 211.5 59.466
Sort 100k rows ms 394.3 783.8 483.8 513.6 141.343
Select 100k rows ms 132.3 388.1 170.5 208.26 91.868
Deselect 100k rows ms 132.4 172 155 155.18 13.235

Generated by 🚫 dangerJS against 505c2c2

@m4theushw m4theushw added the test label Jan 20, 2022
@m4theushw m4theushw merged commit 96b9b86 into mui:master Jan 21, 2022
@m4theushw m4theushw deleted the skip-tests-on-safari branch January 21, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m4theushw @mui-bot @flaviendelangle