[DataGrid] Update selected rows when turning off checkboxSelection
#3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
m4theushw
added
the
component: data grid
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
m4theushw
force-pushed
the
update-selected-rows
branch
from
392b339
to
28e4d1b
Compare
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
m4theushw
force-pushed
the
update-selected-rows
branch
from
28e4d1b
to
151a6e6
Compare
github-actions
bot
removed
the
PR: out-of-date
m4theushw
force-pushed
the
update-selected-rows
branch
from
151a6e6
to
365113a
Compare
m4theushw
force-pushed
the
update-selected-rows
branch
from
365113a
to
84f9544
Compare
packages/grid/_modules_/grid/hooks/features/selection/useGridSelection.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const firstSelectableRow = currentSelection.find((id) => { | ||
| let isSelectable = true; | ||
| if (typeof isRowSelectable === 'function') { |
There was a problem hiding this comment.
Suggested change
| if (typeof isRowSelectable === 'function') { | |
| if (isRowSelectable) { |
Like in line 479. I was looking for what are the other types of isRowSelectable
alexfauquette
approved these changes
Jan 27, 2022
flaviendelangle
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
checkboxSelectionProposed solution
If
checkboxSelectionis turned off, then we cleanselectionModelto keep only one row selected.CodeSandbox with the fix: https://codesandbox.io/s/datagriddemo-material-demo-forked-jjoyn?file=/demo.tsx