[DataGrid] Fix browser keyboard shortcuts not working when header cell is focused #3692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3477 by only preventing default for non registered shortcuts. This behavior applies both for cells and column headers.
Preview: https://deploy-preview-3692--material-ui-x.netlify.app/components/data-grid/demo/
The issue
When a cell / header cell had focus, no keyboard shortcuts would work. The problem was on the
useGridKeyboardNavigation
hook which wasevent.preventDefault()
to any key press.The solution
Only prevent default behavior to shortcuts / keys we are expecting.
Solution provided by @m4theushw