[DataGrid] Clean params of onCellEditCommit
#3693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3442.
The issue
The params sent to
onCellEditCommit
callback function either when clicking outside or pressing Enter / Tab, were inconsistent.The solution
Clean the params to only contain
{id, field, value}
When clicking outside of a cell in editing state, the params sent to the
publishEvent
are now the same as the ones sent when tabbing or pressing enter.<DataGrid onCellEditCommit={e => console.log(e)} rows={rows} columns={columns} />
Actual results:
id, field and value
are the fields received in the paramsSolution provided by @alexfauquette