Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix typo on columnVisibilityModel #3723

Merged
merged 2 commits into from Jan 25, 2022
Merged

[docs] Fix typo on columnVisibilityModel #3723

merged 2 commits into from Jan 25, 2022

Conversation

alexfauquette
Copy link
Member

Fix #3720

@alexfauquette alexfauquette self-assigned this Jan 24, 2022
@mui-bot
Copy link

mui-bot commented Jan 24, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 165.6 418 368.6 307.4 105.661
Sort 100k rows ms 326.4 844.7 728.7 656.12 182.928
Select 100k rows ms 203.6 326 209.6 240.72 47.702
Deselect 100k rows ms 113.6 276.9 196.9 194.02 64.067

Generated by 🚫 dangerJS against 43bb762

m4theushw
m4theushw approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging with master first should fix argos.

@flaviendelangle flaviendelangle merged commit 7e01101 into mui:master Jan 25, 2022
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

Assignees

@alexfauquette alexfauquette

Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Error in columnsVisibilityModel initial state prop (should be columnVisibilityModel).
5 participants
@alexfauquette @mui-bot @m4theushw @oliviertassinari @flaviendelangle