[DataGridPro] Fix missing styleOverrides on pinned columns
#3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
alexfauquette
changed the title
styleOverrides on pinned columns
m4theushw
reviewed
Jan 25, 2022
| @@ -389,6 +389,9 @@ export const gridClasses = generateUtilityClasses('MuiDataGrid', [ | |||
| 'pinnedColumns', | |||
| 'pinnedColumns--left', | |||
| 'pinnedColumns--right', | |||
| 'pinnedColumnHeaders', | |||
There was a problem hiding this comment.
You also need to add these classes to the interface in this same file. The slots docs should also be updated by this PR.
There was a problem hiding this comment.
Is there a reason why we don't reuse the interface keys to generate the list of classes.
I found 3 elements in gridClasses which are not parts of the interface, and I don't know if it is expected or not :
- 'actionsCell'
- 'groupingCriteriaCell'
- 'groupingCriteriaCellToggle'
There was a problem hiding this comment.
I copied the same approach from MUI Core. I don't know how they check to avoid missing classes. cc @mnajdova
oliviertassinari
added
the
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3716
CodeSandbox with the fix: https://codesandbox.io/s/disablecolumnpinningbuttons-material-demo-forked-se9cx?file=/demo.tsx