Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Only update the visibility status of the updates columns when calling apiRef.current.updateRows #3735

Merged
merged 2 commits into from Jan 25, 2022
Merged

[DataGrid] Only update the visibility status of the updates columns when calling apiRef.current.updateRows #3735

merged 2 commits into from Jan 25, 2022

Conversation

flaviendelangle
Copy link
Member

Fixes #3725

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Jan 25, 2022
@flaviendelangle flaviendelangle self-assigned this Jan 25, 2022
@mui-bot
Copy link

mui-bot commented Jan 25, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 155.4 405.5 213.1 266.22 103.243
Sort 100k rows ms 346.5 685.3 519.2 514.32 126.668
Select 100k rows ms 171.8 226.4 195.6 199.88 19.182
Deselect 100k rows ms 104.7 237.6 147.8 158.06 50.993

Generated by 🚫 dangerJS against e8716b9

@flaviendelangle @alexfauquette
Update packages/grid/x-data-grid-pro/src/tests/columnsVisibility.Data…
e8716b9 
…GridPro.test.tsx

Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@flaviendelangle flaviendelangle merged commit ab4f512 into mui:master Jan 25, 2022
@flaviendelangle flaviendelangle deleted the columns-visibility-bug branch January 25, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
3 participants
@flaviendelangle @mui-bot @alexfauquette