Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Create a new lookup with all the filtered rows, collapsed or not #3736

Merged
merged 7 commits into from Jan 25, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jan 25, 2022

Duplicate from #3715 to try fixing a CI issue


Part of #3610

I will modify the default behavior in #3610 or in a standalone PR if #3610 is merged before so that the CSV export has the collapsed rows by default.


In term of naming, we are stuck before v6 with our current "visible" prefix which is not great.
So right now we have:

  • visible => all the rows given to the pagination process, they pass the filtering process AND they are not collapsed.
  • filtered => all the rows that pass the filtering process, whether they are collapsed or not.

We should find a better name than visible in v6 and keep visible for the use case where we are talking about the rows currently displayed on the screen.

@flaviendelangle flaviendelangle self-assigned this Jan 25, 2022
@mui-bot
Copy link

mui-bot commented Jan 25, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 177.2 517 300.2 299.18 123.122
Sort 100k rows ms 344.8 886 654.5 630.6 191.18
Select 100k rows ms 229.3 377.2 348.8 311.8 61.21
Deselect 100k rows ms 139.7 220.9 169.7 177.14 26.535

Generated by 🚫 dangerJS against eb8aa44

@flaviendelangle flaviendelangle merged commit 4c441ff into mui:master Jan 25, 2022
@flaviendelangle flaviendelangle deleted the filter-rows-2 branch January 25, 2022 12:33
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Export new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants