Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve French (frFR) locale #3739

Merged
merged 2 commits into from Jan 26, 2022
Merged

[l10n] Improve French (frFR) locale #3739

merged 2 commits into from Jan 26, 2022

Conversation

flaviendelangle
Copy link
Member

Not fan of the tous, if you have a better suggestion

@flaviendelangle flaviendelangle self-assigned this Jan 25, 2022
@mui-bot
Copy link

mui-bot commented Jan 25, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 225.7 410.5 303.6 303.44 65.577
Sort 100k rows ms 471 769.9 679.2 629.44 127.172
Select 100k rows ms 163 271.3 222.6 213.46 37.99
Deselect 100k rows ms 147.4 231.3 189.4 194.8 29.089

Generated by 🚫 dangerJS against 15d9efa

@alexfauquette
Copy link
Member

For the tous could it be left it empty? Because filtering with "any" is like filtering with no value

@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 25, 2022
@flaviendelangle flaviendelangle merged commit bd46b18 into mui:master Jan 26, 2022
@flaviendelangle flaviendelangle deleted the fr-Fr branch January 26, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flaviendelangle @mui-bot @alexfauquette @oliviertassinari