New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix country column sorting not working #3740
Merged
cherniavskii
merged 9 commits into
mui:master
from
cherniavskii:docs-country-sorting-demo
Jan 31, 2022
Merged
[docs] Fix country column sorting not working #3740
cherniavskii
merged 9 commits into
mui:master
from
cherniavskii:docs-country-sorting-demo
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sort by label, so that options in filter select are sorted alphabetically
cherniavskii
commented
Jan 25, 2022
@@ -325,4 +325,4 @@ export const COUNTRY_ISO_OPTIONS = [ | |||
{ value: 'ZA', code: 'ZA', label: 'South Africa', phone: '27' }, | |||
{ value: 'ZM', code: 'ZM', label: 'Zambia', phone: '260' }, | |||
{ value: 'ZW', code: 'ZW', label: 'Zimbabwe', phone: '263' }, | |||
]; | |||
].sort((v1, v2) => v1.label.localeCompare(v2.label)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure countries are sorted alphabetically in filter select
These are the results for the performance tests:
|
oliviertassinari
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
Jan 25, 2022
packages/grid/x-data-grid-generator/src/commodities.columns.tsx
Outdated
Show resolved
Hide resolved
flaviendelangle
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3681
It exposed few things that I'm going extract to a separate issue:
improve
sortComparator
typing. [DataGrid] ImprovesortComparator
typing #3741Currently for TypeScript to stop complaining users have to use type assertion, e.g.:
Add runtime warning if
valueSetter
is missing.According to docs:
It looks like
valueSetter
is required when column is editable and hasvalueGetter
.If so, we should add a console warning in this case.