[DataGrid] Add l10n support for 'is any of' #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
Do you know why ? |
|
No, otherwise I would have made the fix ;) I do not see any difference with other locale files Probably better to open an issue for that |
2 tasks
|
@flaviendelangle Andrew corrected the bug on csCZ file. It was a typo in the name of the exported variable |
flaviendelangle
approved these changes
Jan 27, 2022
cherniavskii
added
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3743
When running
yarn l10nthe csCZ file is not updated. I did it manuallyThe file is open, but it has an early return due to this condition https://github.com/alexfauquette/material-ui-x/blob/fix-isAnyLabel/scripts/l10n.ts#L266:L268