[test] Include module augmentation for Chai custom matchers #3754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
1 task
| @@ -4,5 +4,5 @@ | |||
| "noEmit": true, | |||
| "types": ["mocha", "node", "chai", "chai-dom"] | |||
| }, | |||
| "include": ["src"] | |||
| "include": ["src", "../../../node_modules/@mui/monorepo/test/utils/initMatchers.ts"] | |||
There was a problem hiding this comment.
Is there something preventing us from adding it to the root tsconfig.json file of the repo ?
There was a problem hiding this comment.
Yes, include in the root tsconfig.json gets overwritten by the package tsconfig.json when extending. https://www.typescriptlang.org/tsconfig#extends
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
m4theushw
commented
Jan 27, 2022
| @@ -116,8 +116,7 @@ describe('<DataGrid /> - Cells', () => { | |||
| fireEvent.click(getCell(0, 0)); | |||
|
|
|||
| expect(() => { | |||
| fireEvent.focus(getCell(1, 0)); | |||
| // @ts-expect-error need to migrate helpers to TypeScript | |||
| getCell(1, 0).focus(); | |||
There was a problem hiding this comment.
I changed to fireEvent by mistake in #3752.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the core repo,
test/utils/initMatchers.tsis within thebaseUrlof the roottsconfig.json, so the module augmentation also gets included. In the X repo, this file is not part of the root directory. It's only included when running the tests, so the TypeScript compiler can't see the new types. My solution was to explicitly include the file in eachtsconfig.json. It had to be done in each config because of the way that TypeScript handles config inheritance.The monorepo was updated to get mui/material-ui#30798.