Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix PageUp jumping directly to the column header skipping the first row #3761

Merged
merged 6 commits into from Jan 31, 2022
Merged

[DataGrid] Fix PageUp jumping directly to the column header skipping the first row #3761

merged 6 commits into from Jan 31, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jan 27, 2022 •
edited

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Jan 27, 2022
@mui-bot
Copy link

mui-bot commented Jan 27, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 1,171.5 1,812.6 1,489.9 1,519.02 236.067
Sort 100k rows ms 715 1,109.2 715 926.24 148.112
Select 100k rows ms 131.2 269.4 169.3 193.38 60.358
Deselect 100k rows ms 85.3 202 166.7 139.1 42.097

Generated by 🚫 dangerJS against 2dd053f

@cherniavskii cherniavskii merged commit f6469fb into master Jan 31, 2022
@cherniavskii cherniavskii deleted the fix-page-up-navigation branch January 31, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
accessibility a11y bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] Keyboard navigation with variable row height
3 participants
@cherniavskii @mui-bot @flaviendelangle