Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add default value for Row slot #3807

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Feb 1, 2022

Just noticed that there's no default value mentioned in docs.

TODO:

@cherniavskii
Copy link
Member Author

I've noticed that yarn docs:api is broken - it silently fails, I will fix it in a separate PR

@mui-bot
Copy link

mui-bot commented Feb 2, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 196.1 378.2 293.8 292.26 60.646
Sort 100k rows ms 375.5 778.6 608.3 596.84 129.079
Select 100k rows ms 181.3 211 194.2 193.58 10.89
Deselect 100k rows ms 123.7 218.2 184.4 170.92 37.034

Generated by 🚫 dangerJS against 0fe77dd

@cherniavskii cherniavskii marked this pull request as ready for review February 2, 2022 14:42
@cherniavskii cherniavskii added the docs Improvements or additions to the documentation label Feb 3, 2022
@cherniavskii cherniavskii merged commit a56b6a5 into master Feb 3, 2022
@cherniavskii cherniavskii deleted the docs-default-row-slot branch February 3, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants