[Dialog] Create new component and hook #372
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
new feature
atomiks
reviewed
May 1, 2024
Comment on lines
68
to
77
| if (modal) { | ||
| // When the dialog is modal, clicking on the backdrop is recognized as clicking on the dialog itself. | ||
| // We need to check whether the click was outside the dialog's bounding box. | ||
| // We also don't want to close the dialog when clicking on any descendant of it (such as an open select). | ||
| if ( | ||
| (event.target === popupElement && hasClickedOutsideBoundingBox(event, popupElement)) || | ||
| !popupElement.contains(event.target as Node) | ||
| ) { | ||
| onOpenChange?.(false); | ||
| } |
There was a problem hiding this comment.
Several issues with "outside click" detection popped up in Floating UI:
- The dialog shouldn't close if you clicked on the scrollbar if present, since they may be trying to scroll.
- The
containscheck needs to handle portaled elements that aren't a direct descendant of the dialog in the DOM and also shadow DOM elements. - It shouldn't close if clicking a third-party widget (e.g. extension popup or toast) that appeared up after the dialog was rendered over the top. (This actually may bring about another problem I saw a few months ago - third-party widgets that don't use top-layer elements can't ever appear over the dialog itself? This includes Grammarly popups, translation popups, etc.)
- "Click outside" should use
mousedownnotpointerdownsince touch events can fire on elements beneath the backdrop with touch input unintentionally otherwise when dimissing.
There was a problem hiding this comment.
We can solve almost all of these problems with our ClickAwayListener. The only issue that remains is the top-layer thing. I've investigated this for a while, but I don't think we can work around it, unfortunately.
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
atomiks
reviewed
May 24, 2024
Comment on lines
+71
to
+73
| * Determines whether the dialog should close when clicking outside of it or pressing the escape key. | ||
| */ | ||
| softClose: SoftCloseOptions; |
There was a problem hiding this comment.
MDN docs call this light dismiss instead. I also think it should be the default if it isn't here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-372--base-ui.netlify.app/base-ui/react-dialog/
Closes #215