[Context Api] React 16.6.0

[jamalsoueidan]

I'm getting this warning when I upgraded to the latest react version.

WithStyles(xxx) declares both contextTypes and contextType static properties. The legacy contextTypes property will be ignored.

This is related to the new context API.

[oliviertassinari]

@jamalsoueidan Thank you for the feedback. I'm closing for #13394.

[AlekzZz]

@oliviertassinari aren't those 2 separate issues? @jamalsoueidan is having same issue i get, and it is related to using new context property static contextType vs the legacy one used by withStyles, so when both ways are defined, react keeps the new version, while making withStyles to stop working.

[oliviertassinari]

@AlekzZz I haven't realized it's breaking everything. Ok, we have been buying some time (multiple months) but not updating the old context API usage. It's time!

[jamalsoueidan]

@AlekzZz correct 👍

[jamalsoueidan]

Is it fixed @oliviertassinari so I can upgrade material ui :) ?

[jamalsoueidan]

Close?

[eps1lon]

@jamalsoueidan This should still be an issue since withStyles is still using the deprecated context API. Can you confirm that the message WithStyles(xxx) declares both contextTypes and contextType static properties. The legacy contextTypes property will be ignored. is not appearing anymore?

[oliviertassinari]

We should have been taken care of all the usages of the old react context usage! ✨ @eps1lon 👏

[eps1lon]

I think this originated in hoist-non-react-statics which only stopped hoisting contextType in hoist-non-react-statics@3.1.0. Before hoist-non-react-statics@3.1.0 withStyles would hoist contextType of the decorated component into the WithStyles component which uses contextTypes (heed the plural form). This would create a component with contextType and contextTypes which would create the reported error message.

So this was actually resolved once people updated their dependencies after hoist-non-react-statics@3.1.0 was released.