[RFC] createElement changes

[eps1lon]

This is a premature tracking issue for changes in reactjs/rfcs#107 that would affect this repository. Don't actually allocate time to this issue. Just something you might want to keep in the back of you head.

defaultProps and function components

Deprecate defaultProps on function components.

• need to investigate implications for react-docgen
• assuming we stick with not destructuring props in the function signature

function Component(props) {
-  const { someProp, anotherProp } = props;
+  const { someProp = 'default', anotherProp } = props;
}
-Component.defaultProps = {
-  someProp: 'defaulted'
-};

Looks doable for static analysis. If anybody encounters other patterns please post them here.

related discussions

• [MenuList] Convert to a function component #14865 (comment)

key spreading

Deprecate spreading key from objects.

Unknown if we do this

refs

Move ref extraction to class render time and forwardRef render time.

As far as I understood this we can get rid of React.forwardRef on function components and instead of

const Component = React.forwardRef(function Component(props, ref) {
  return <div ref={ref} {...props} />;
});

do

function Component(props) {
  return <div {...props} />;
};

which is equivalent to

function Component({ ref, ...props }) {
  return <div ref={ref} {...props} />;
};

Really glad about this change. Although it would've been nice if this had landed with the findDOMNode deprecation 😩

[oliviertassinari]

@eps1lon Do we need to keep this issue open? It seems that reactjs/rfcs#107 hasn't made progress.

[eps1lon]

I haven't made any progress in investigating if we spread keys. As long as the RFC is open this should stay open as well.

[oliviertassinari]

As long as the RFC is open this should stay open as well.

@eps1lon Ok, this sounds like a great strategy. I will listen to the close event on this React rfcs issue.

---

This made me wonder. Do you think that it would be interesting for Material-UI to have an https://github.com/mui-org/rfcs repository?