Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lowercase property to Button #18175

Closed
1 task done
lcswillems opened this issue Nov 4, 2019 · 4 comments
Closed
1 task done

Add lowercase property to Button #18175

lcswillems opened this issue Nov 4, 2019 · 4 comments
Labels
component: button This is the name of the generic UI component, not the React module! discussion out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@lcswillems
Copy link
Contributor

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 馃挕

It is specified in the Material design spec that Container Button can be sentence cased: https://material.io/components/buttons/#contained-button

It would be nice to add a sentenceCase property.

Examples 馃寛

<Button sentenceCase>My button</Button>
@lcswillems lcswillems changed the title Add lowercase attribute to Button Add lowercase property to Button Nov 4, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 4, 2019 •
edited

@lcswillems Use customizations for this problem (text-transform).

@oliviertassinari oliviertassinari added component: button This is the name of the generic UI component, not the React module! out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) labels Nov 4, 2019
@lcswillems
Copy link
Contributor Author

This is what I do but why? Customizations are for changing the spec. It doesn't make sense for me to have to implement the spec manually.

@oliviertassinari
Copy link
Member

I think that it boils down to how frequently would you use it? It opens the door to inconsistencies in your UI. I doubt we need a prop for it.

Capture d鈥檈虂cran 2019-11-04 a虁 12 50 17

@oliviertassinari oliviertassinari added discussion and removed out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) labels Nov 4, 2019
@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Dec 10, 2019
@snyk-bot snyk-bot mentioned this issue Oct 28, 2020
Open
@hzhz hzhz mentioned this issue Mar 8, 2021
Open
@snyk-bot snyk-bot mentioned this issue Aug 27, 2021
Open
@snyk-bot snyk-bot mentioned this issue Sep 16, 2021
Open
@PunkFleet
Copy link

text-transform

@lcswillems Use customizations for this problem (text-transform).

Hi, How do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! discussion out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @lcswillems @PunkFleet