Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TouchRipple] Document of TouchRipple Component #19738

Closed
1 task done
Losses opened this issue Feb 16, 2020 · 5 comments
Closed
1 task done

[TouchRipple] Document of TouchRipple Component #19738

Losses opened this issue Feb 16, 2020 · 5 comments
Labels
support: question Community support but can be turned into an improvement

Comments

@Losses
Copy link
Contributor

Losses commented Feb 16, 2020

It seems that there isn't a document for TouchRipple Component, can we have one? :)

  • I have searched the issues of this repository and believe that this is not a duplicate.
@Losses
Copy link
Contributor Author

Losses commented Feb 16, 2020

BTW, is it possible to make TouchRipple (or CircleRipple) receive class props, so users can customize the style of it?

@mbrookes
Copy link
Member

TouchRipple isn't documented because it's an internal component. What's your use-case?

@Losses
Copy link
Contributor Author

Losses commented Feb 17, 2020

@mbrookes We are implementing a set of heavily customized components, which need CSS variable as theme controller to adjust colors. It's known that the styling system of material and CSS variables didn't play well with each other, so we are thinking if we could only use TouchRipple / CircleRipple component directly.

@mbrookes
Copy link
Member

In that case I think you may be best to clone the component into your project, and make the changes you need locally.

@Losses
Copy link
Contributor Author

Losses commented Feb 18, 2020

Hmmmmm, maybe you are right...

@Losses Losses closed this as completed Feb 18, 2020
@zannager zannager added the support: question Community support but can be turned into an improvement label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: question Community support but can be turned into an improvement
Projects
None yet
Development

No branches or pull requests

3 participants