Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next demo] Customized Snackbar clicking "Open Success Snackbar" gives runtime error #21858

Closed
1 of 2 tasks
bcjordan opened this issue Jul 20, 2020 · 7 comments · Fixed by #21883
Closed
1 of 2 tasks

[next demo] Customized Snackbar clicking "Open Success Snackbar" gives runtime error #21858

bcjordan opened this issue Jul 20, 2020 · 7 comments · Fixed by #21883
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Milestone
v5-beta

Comments

@bcjordan
Copy link

bcjordan commented Jul 20, 2020 •
edited

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Demo crashes and requests I report the issue here.

image

Expected Behavior 🤔

Demo does something after clicking

Steps to Reproduce 🕹

Steps:

  1. Go to https://next.material-ui.com/components/snackbars/#customized-snackbars
  2. Under Customized snackbars --> click Open Success Snackbar

Context 🔦

Want to see what Snackbar does in next.material-ui

Your Environment 🌎

Tech Version
Material-UI next (whichever is on next website)
Browser Chrome
@bcjordan bcjordan added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 20, 2020
@bcjordan bcjordan changed the title [next demo] Customized Snackbar demo runtime error [next demo] Customized Snackbar clicking "Open Success Snackbar" gives runtime error Jul 20, 2020
@oliviertassinari
Copy link
Member

Seems related to #21811

@eps1lon eps1lon added bug 🐛 Something doesn't work docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 20, 2020
@eps1lon eps1lon added this to the v5 milestone Jul 20, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 20, 2020 •
edited

I suspect an issue with react-transition-group, I didn't look deep, I have seen a few troubling behaviors.

@eps1lon
Copy link
Member

eps1lon commented Jul 20, 2020

I have seen a few troubling behaviors.

For example?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 20, 2020 •
edited

I have seen react-transition-group raise a warning about a wrong prop type HTMLElement vs HTMLDivElement, I don't see any structural difference between the demo and the others. Now, I didn't look deep, nor plan to. Forget my previous comment, it's noise :).

@eps1lon
Copy link
Member

eps1lon commented Jul 20, 2020

I have seen react-transition-group raise a warning about a wrong prop type HTMLElement vs HTMLDivElement

Where?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 20, 2020 •
edited

On the same page:
Capture d’écran 2020-07-20 à 18 43 53

Which seems to be an issue with using iframe

@oliviertassinari
Copy link
Member

Never mind, different problem https://github.com/reactjs/react-transition-group/pull/619#discussion_r420847211…

@oliviertassinari oliviertassinari mentioned this issue Jul 20, 2020
Merged
@eps1lon eps1lon mentioned this issue Jul 22, 2020
Merged
@oliviertassinari oliviertassinari mentioned this issue Jul 25, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
v5-beta
Development

Successfully merging a pull request may close this issue.

[core] Add warnings where ref-forwarding components/elements are required eps1lon/material-ui
3 participants
@bcjordan @oliviertassinari @eps1lon