Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Replace react-text-mask with react-imask in integration example #27071

Merged
merged 7 commits into from
Jul 9, 2021

Conversation

michal-perlakowski
Copy link
Contributor

@michal-perlakowski michal-perlakowski commented Jul 2, 2021

michal-perlakowski and others added 7 commits April 10, 2021 10:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 2, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 4b1f549

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mnajdova mnajdova merged commit 5e70152 into mui:next Jul 9, 2021
@michal-perlakowski michal-perlakowski deleted the mask branch July 9, 2021 13:16
@@ -19,3 +19,5 @@ declare module 'docs/src/modules/components/HighlightedCode' {
}

declare module '@trendmicro/react-interpolate';

declare module 'react-imask';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this is kinda misleading because the examples don't mention that one has to override react-imask types to make it work. Otherwise there is a type error as mentioned in #30854

@zannager zannager added the docs Improvements or additions to the documentation label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] react-text-mask 3rd party input integration is unmaintained
6 participants