[test] Narrow down React 18 compat issues #27134
Merged
+37
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
test/react-next-update
branch
from
bd51b11 to
61709e3
Compare
eps1lon
force-pushed
the
test/react-next-update
branch
from
61709e3 to
0b5ba04
Compare
This reverts commit a7fda45.
eps1lon
commented
Jul 5, 2021
Comment on lines
+2053
to
+2056
| // TODO: React18 compat | ||
| // on*Change should only be called if the highlighted option changes. | ||
| // Investigate why this is called in the first place considering this looks like derived state. | ||
| legacyRoot: true, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run with React 18: https://app.circleci.com/pipelines/github/mui-org/material-ui/48869/workflows/b7c27f8a-58ee-4f51-8a25-995ea248da06