Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove usage of url package #27151

Merged
merged 1 commit into from
Jul 8, 2021
Merged

[docs] Remove usage of url package #27151

merged 1 commit into from
Jul 8, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 6, 2021

Noticed that we're using the url polyfill which isn't even a declared dependency. I suspect that the package is responsible for #26943.

Closes #26943

Preview: https://deploy-preview-27151--material-ui.netlify.app/

@eps1lon eps1lon added docs Improvements or additions to the documentation performance labels Jul 6, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 6, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against d211bbd

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets us one step closer to webpack 5, by removing the auto-polyfilled dependency 👍. We could consider adding Sentry to a small percentage of the sessions to see what we get. Without a reproduction, it's hard to tell if we fix the issue.

@eps1lon
Copy link
Member Author

eps1lon commented Jul 8, 2021

We could consider adding Sentry to a small percentage of the sessions to see what we get. Without a reproduction, it's hard to tell if we fix the issue.

Glad to hear it. Will take a look since this'll be interesting for A/B testing the docs with React 18.

@eps1lon eps1lon merged commit c6642e3 into mui:next Jul 8, 2021
@eps1lon eps1lon deleted the docs/url branch July 8, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Failed to construct 'URL': Please use the 'new' operator.
3 participants