[Autocomplete] Add componentsProps #27183
Merged
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update branch
michaldudak
reviewed
Jul 8, 2021
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
|
I'm wondering if we shouldn't support other slots' props as well, for consistency. @oliviertassinari, any thoughts? |
oliviertassinari
added
component: autocomplete
oliviertassinari
force-pushed
the
autocomplete-componentsprops
branch
from
8cf2558 to
54cd264
Compare
|
@michaldudak No real preferences. We could add more now, or later. I pushed a commit to have the class names merge, not replace. |
michaldudak
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18150.
Demo: https://codesandbox.io/s/create-react-app-forked-ckdlz