[docs] Reduce layout shift on landing page #27251
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
reviewed
Jul 13, 2021
|
|
||
| return ( | ||
| <div className={classes.root}> | ||
| <Typography variant="caption">{t('homeQuickWord')}</Typography> | ||
| <NoSsr defer> | ||
| {backer === null ? ( | ||
| <Typography variant="body2"> </Typography> |
mnajdova
approved these changes
Jul 13, 2021
|
Since Danilo and Jun targets to rewrite this page by the end of the summer, I guess the main value is to get a high baseline we can compare the new implementation against 😈, ideally we would get 0 layout shift. |
That will be the next step. I think it's only caused by font loading and for that we may be able to leverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the cumulative layout shift to 0.002 (was 0.003).