[ModalUnstyled] Fix errors from the W3C validator about incorrect aria-hidden attribute on some elements #30920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-hidden attribute on some elements
mnajdova
requested changes
May 18, 2022
|
I've done the changes. |
mnajdova
approved these changes
Jun 8, 2022
mnajdova
added
accessibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Dialogcomponent with a container having siblings like<noscript>, the generated code gets an error from the W3C validator saying:This happens for everyone using Create React App with the default HTML code in the
public/directory, and letting the default modal container to<body>.Here is a reproduction from Create React App and Material UI example, that has a simple
Dialogand a few sibling elements that get thearia-hiddenattribute but should not.Some tags were already excluded from getting
aria-hiddenon them, so it was easy for me to add more of them. I went through the ARIA in HTML specification and took all the tags that could be children of body with the mentionNo role or aria-* attributes, to exclude them too.