[docs] Fix the docs for production class generation #31933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
mnajdova
reviewed
May 18, 2022
| @@ -444,7 +444,7 @@ const className = `${sheetName}-${ruleName}-${identifier}`; | |||
| const productionPrefix = 'jss'; | |||
| const identifier = 123; | |||
|
|
|||
| const className = `${productionPrefix}-${identifier}`; | |||
| const className = `${productionPrefix}${identifier}`; | |||
There was a problem hiding this comment.
Note that we are not manually changing the translation files, please revert the changes to the advanced-pt.md and the advanced-zh.md files.
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs are not aligned with the actual code. At this very moment the class generation for the "dev" environment and the "prod" environment is different:
^ notice no hyphen before the counter ID in the prod one
See also the code:
https://github.com/mui/material-ui/blob/master/packages/mui-styles/src/createGenerateClassName/createGenerateClassName.js#L69
I believe it's a typo, but changing this logic would introduce a breaking change, so I'm suggesting at least updating the docs.