Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add note in the Contributing guide about linking issues to a PR #32174

Merged
merged 6 commits into from Apr 12, 2022

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 7, 2022

A small thing that I have been doing quite frequently in PRs out there, that makes life a bit easier, and the community should know! :)

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Apr 7, 2022
@mui-bot
Copy link

mui-bot commented Apr 7, 2022

No bundle size changes

Generated by 🚫 dangerJS against 528643a

Copy link
Contributor Author

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iterating a bit — self reviewing 😅

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
danilo-leal and others added 2 commits April 12, 2022 12:09
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
@danilo-leal danilo-leal merged commit 19c0ad3 into mui:master Apr 12, 2022
@danilo-leal danilo-leal deleted the update-contributing-file branch April 12, 2022 20:40
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 12, 2022

Iterating a bit — self reviewing

I think that it's a great habit 👌, It helped me tremendously in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants