Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Update product descriptions and social preview images #32181

Merged
merged 14 commits into from
Dec 15, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 7, 2022

End of 2023 edit to this PR description: adding social previews (or open graph) images to each one of our marketing pages. I've updated their descriptions to match what's used in the hero title of each one as well as images for those that weren't initially accounted for in the very first iteration of this PR 😌

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@danilo-leal danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Apr 7, 2022
@mui-bot
Copy link

mui-bot commented Apr 7, 2022

Netlify deploy preview

https://deploy-preview-32181--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 96fbbed

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave the decision to you, @oliviertassinari and @samuelsycamore but here are my thoughts.

MUI Core

- Foundational components for shipping features faster
+ Comprehensive components for shipping UIs faster

MUI X

- Advanced components for complex use cases
+ Advanced components for sophisticated use cases.

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 8, 2022

I would leave the decision to you, @oliviertassinari and @samuelsycamore but here are my thoughts.

No matter what we pick, shouldn't it be in sync?

Screenshot 2022-04-08 at 17 49 28

and

Screenshot 2022-04-08 at 17 50 36

So we have a single description.

https://master--material-ui.netlify.app/core/

@danilo-leal
Copy link
Contributor Author

Yes, absolutely! Thanks for pointing that out, I'll make sure to update those as well.

@mapache-salvaje
Copy link
Contributor

mapache-salvaje commented Apr 8, 2022

Personally I'm partial to the wording as it is in the updated social images (though of course I'm biased because I wrote it 😅). It also matches the homepage copy revisions PR that we merged yesterday. I do like the word "Comprehensive" in @siriwatknp's suggestion but I think that's better suited as a descriptor of our "libraries" rather than the "components," if that makes sense. (e.g. "Our comprehensive UI library contains all of the foundational components you need" etc.)

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of wording in "Design kits" looks great, I would challenge the others.

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 13, 2022

I have just merged #32211 which syncs what we have in the npm package description (slave) and what we have on mui.com (source of truth).
If we change what we have on mui.com in this PR (effectively going beyond the title "update the social preview images), please also keep the pacakge.json in sync.

@mbrookes
Copy link
Member

Wording aside, I wonder if the new font size is big enough at the resolution these images will be rendered at? It's certainly not great at the GitHub preview size on a non-retina monitor (It's 3440 × 1440, 34" wide-screen).

@danilo-leal
Copy link
Contributor Author

Yup, thought the same. Please check again!

@danilo-leal danilo-leal changed the title [website] Update the social preview images [website] Update product descriptions and social preview images Apr 13, 2022
@danilo-leal
Copy link
Contributor Author

@oliviertassinari I'll need your help to change it in other places outside the website, like Twitter, LinkedIn, etc. Let me know if there are more of them!

@oliviertassinari
Copy link
Member

Happy to do it, and to look into how to give the the access for others to do it. I will wait for this PR to be merged though.

@mapache-salvaje
Copy link
Contributor

Is everyone happy with the wording on these cards? If so, I think we should use this copy as the main source of truth across our marketing site and docs. Should we use this PR to update the mui.com homepage, or create a new PR?

@mbrookes
Copy link
Member

I will wait for this PR to be merged though

Should we not wait for the logo PR to be merged first? (Not sure why that stalled.)

@danilo-leal
Copy link
Contributor Author

Yeah, guess so. I'll try to get back to that when possible.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 19, 2022

What's missing with this PR to move forward? Maybe we could start with the descriptions, and once we are aligned with them, move to update the visuals (in a different PR, there will be a LOT of them to update)?

@mbrookes
Copy link
Member

What's missing with this PR to move forward?

  • Removing the graph-paper noise, and possibly the gradient.
  • Updating with the revised logo once that PR is merged.

@michaldudak
Copy link
Member

@danilo-leal, any chance we could move this forward? It's been approved for well over a year now.

@danilo-leal
Copy link
Contributor Author

@michaldudak Yeah ⎯ we could either move forward now, without new logos for each product, or wait until we have them ready to go. What do you think? I'm leaning toward the second option there.

@michaldudak
Copy link
Member

👍 All right. I just wanted to have a clearer picture of the plans for this PR.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 12, 2023
@danilo-leal
Copy link
Contributor Author

@oliviertassinari + @samuelsycamore + @mbrookes — would love it if you all could take a refreshed look at this PR!

@mbrookes
Copy link
Member

The content LGTM, but the file sizes seem disproportionate (10X the previous ones). Given the graduated background (if that's the right term?) perhaps JPEG is the better format?

I don't think it will move the needle enough to help, but we also used to run all images through https://imageoptim.com/.

Probably out of scope here, as I imagine it would have to be changed elsewhere, but have we considered using the same typeface for MUI as on docs/public/static/social-previews/home-preview.png as for the other cards? Always thought that looked a bit out of place.

@danilo-leal
Copy link
Contributor Author

danilo-leal commented Dec 15, 2023

(Rambling warning ↓ we can expand on this elsewhere, too!)

We can definitely iterate on the typeface we're currently using for the "MUI" wordmark! Earlier this year, I was exploring some other fonts to move away from what we had earlier for headings, Jakarta, and landed on Lexend — the current one I'm using on the image, and in general, for the logo. It's a super extensible font family (and variable!), but still, I wasn't feeling it for the actual documentation and website headings. It did feel great for the logo wordmark, though, particularly because of a stylistic set that contains that serif I, which has always been a pet peeve of mine when seeing "MUI" written with a standard sans serif font — the M and U characters are super wide, whereas the I is so thin; looks unbalanced. Then, as usual in my reference-seeking process, I always, at least quickly, check Stripe up. And then, I realized, given they don't have a "logo icon" (it's just either the full stripe word written or just the S), they use one font for that (FF Fago), and another for their website, docs, and app (Söhne)! Then others came to mind (Airbnb, Slack, Tumblr), to which point, it made me feel like it wasn't super weird or a too inconsistent move. 😅 However, with all of that said, I do see it's not a fully solved problem as we have MUI-prefixed product names, and in those images, I'm using the font we're now currently using for headings (General Sans), and thus, my pet peeve is still there, and then, it starts to feel inconsistent as any "MUI" mention should probably use the logo font when in imagery settings like this? Not sure. But, anyway! Happy to iterate more, and we'll likely need to in the near future!

@mbrookes
Copy link
Member

Thanks for the detailed feedback on your thought process! Lots of moving parts. Let's move it offline. Happy to be a sounding board!

@mbrookes mbrookes merged commit e7b9793 into mui:master Dec 15, 2023
@danilo-leal danilo-leal deleted the update-social-preview-images branch December 15, 2023 21:05
oliviertassinari added a commit that referenced this pull request Jan 4, 2024
Fix a quick regression introduced in #32181
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Fix a quick regression introduced in mui#32181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants