-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Update product descriptions and social preview images #32181
[website] Update product descriptions and social preview images #32181
Conversation
Netlify deploy previewhttps://deploy-preview-32181--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave the decision to you, @oliviertassinari and @samuelsycamore but here are my thoughts.
MUI Core
- Foundational components for shipping features faster
+ Comprehensive components for shipping UIs faster
MUI X
- Advanced components for complex use cases
+ Advanced components for sophisticated use cases.
…te-social-preview-images
No matter what we pick, shouldn't it be in sync? and So we have a single description. |
Yes, absolutely! Thanks for pointing that out, I'll make sure to update those as well. |
Personally I'm partial to the wording as it is in the updated social images (though of course I'm biased because I wrote it 😅). It also matches the homepage copy revisions PR that we merged yesterday. I do like the word "Comprehensive" in @siriwatknp's suggestion but I think that's better suited as a descriptor of our "libraries" rather than the "components," if that makes sense. (e.g. "Our comprehensive UI library contains all of the foundational components you need" etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change of wording in "Design kits" looks great, I would challenge the others.
I have just merged #32211 which syncs what we have in the npm package description (slave) and what we have on mui.com (source of truth). |
Wording aside, I wonder if the new font size is big enough at the resolution these images will be rendered at? It's certainly not great at the GitHub preview size on a non-retina monitor (It's 3440 × 1440, 34" wide-screen). |
Yup, thought the same. Please check again! |
@oliviertassinari I'll need your help to change it in other places outside the website, like Twitter, LinkedIn, etc. Let me know if there are more of them! |
Happy to do it, and to look into how to give the the access for others to do it. I will wait for this PR to be merged though. |
Is everyone happy with the wording on these cards? If so, I think we should use this copy as the main source of truth across our marketing site and docs. Should we use this PR to update the mui.com homepage, or create a new PR? |
Should we not wait for the logo PR to be merged first? (Not sure why that stalled.) |
Yeah, guess so. I'll try to get back to that when possible. |
What's missing with this PR to move forward? Maybe we could start with the descriptions, and once we are aligned with them, move to update the visuals (in a different PR, there will be a LOT of them to update)? |
|
@danilo-leal, any chance we could move this forward? It's been approved for well over a year now. |
@michaldudak Yeah ⎯ we could either move forward now, without new logos for each product, or wait until we have them ready to go. What do you think? I'm leaning toward the second option there. |
👍 All right. I just wanted to have a clearer picture of the plans for this PR. |
@oliviertassinari + @samuelsycamore + @mbrookes — would love it if you all could take a refreshed look at this PR! |
The content LGTM, but the file sizes seem disproportionate (10X the previous ones). Given the graduated background (if that's the right term?) perhaps JPEG is the better format? I don't think it will move the needle enough to help, but we also used to run all images through https://imageoptim.com/. Probably out of scope here, as I imagine it would have to be changed elsewhere, but have we considered using the same typeface for MUI as on docs/public/static/social-previews/home-preview.png as for the other cards? Always thought that looked a bit out of place. |
(Rambling warning ↓ we can expand on this elsewhere, too!) We can definitely iterate on the typeface we're currently using for the "MUI" wordmark! Earlier this year, I was exploring some other fonts to move away from what we had earlier for headings, Jakarta, and landed on Lexend — the current one I'm using on the image, and in general, for the logo. It's a super extensible font family (and variable!), but still, I wasn't feeling it for the actual documentation and website headings. It did feel great for the logo wordmark, though, particularly because of a stylistic set that contains that serif |
Thanks for the detailed feedback on your thought process! Lots of moving parts. Let's move it offline. Happy to be a sounding board! |
Fix a quick regression introduced in #32181
Fix a quick regression introduced in mui#32181
End of 2023 edit to this PR description: adding social previews (or open graph) images to each one of our marketing pages. I've updated their descriptions to match what's used in the hero title of each one as well as images for those that weren't initially accounted for in the very first iteration of this PR 😌